DDSLoader: Fix incorrect alpha when loading 24-bit uncompressed textures. #30598
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When loading 24-bit uncompressed DDS texture, alpha value was mistakingly set to 1 instead of 255, resulting in almost fully transparent mesh when using
BasicMeshMaterial
withtransparent: true
option.I have updated
webgl_loader_texture_dds.html
to includetransparent: true
, so bug could be seen in practice:Before fix:
After fix:
Screenshot was regenerated with
npm run make-screenshot webgl_loader_texture_dds
, but there are no visible changes (I can delete this change).